fix(output): drain buffered records on TCP/UDP Stop (PIPE-1230) - #271
Open
Dylan-M wants to merge 1 commit into
Open
fix(output): drain buffered records on TCP/UDP Stop (PIPE-1230)#271Dylan-M wants to merge 1 commit into
Dylan-M wants to merge 1 commit into
Conversation
…ng them (PIPE-1230) Assisted-by: Claude Opus 4.8
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Proposed Change
The TCP and UDP outputs could drop buffered records on
Stop().Stop()closed the data channel and cancelled the worker context at the same time. The worker's select then chose at random between draining the channel and taking the cancelled context, so it often exited with records still buffered.Stop()now stops the workers first, then drains whatever is still buffered before returning. With the workers gone the drain is the only reader, so delivery is deterministic. The drain is bounded by the write timeout, the stop timeout, and the caller's context. An unreachable destination can't hang shutdown.How to validate
go test -race ./output/tcp/ ./output/udp/passes. New tests cover the drain (records buffered atStopall arrive), an unreachable destination (Stopreturns without hanging), and the send-failure and context-cancelled paths.drainBufferedanddrainToare at 100% coverage.Stop, and confirm the listener receives all of them.Checklist